Skip to content

Commit

Permalink
[WIP]
Browse files Browse the repository at this point in the history
  • Loading branch information
@jongpie
jongpie committed Sep 12, 2024
1 parent 9395e08 commit ca46021
Show file tree
Hide file tree
Showing 2 changed files with 60 additions and 31 deletions.
7 changes: 1 addition & 6 deletions nebula-logger/core/main/logger-engine/classes/CallableLogger.cls
View file
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ global without sharing class CallableLogger implements System.Callable {
}
when else {
isSuccess = false;
errorMessage = 'Unsupported action: ' + action;
errorMessage = 'Unknown action: ' + action;
}
}

Expand Down Expand Up @@ -148,11 +148,6 @@ global without sharing class CallableLogger implements System.Callable {
output.put(OUTPUT_ARGUMENT_CALL_IS_SUCCESS, true);
}
when 'saveLog' {
// System.debug('>>> action: ' + action);
// System.debug('>>> input: ' + System.JSON.serializePretty(input));
// String stuff = '>>> action: ' + action + '\n' + '>>> input: ' + System.JSON.serializePretty(input);
// System.Assert.fail('>>> stuff: ' + stuff);

this.saveLog(input);
output.put(OUTPUT_ARGUMENT_CALL_IS_SUCCESS, true);
}
Expand Down
84 changes: 59 additions & 25 deletions nebula-logger/core/tests/logger-engine/classes/CallableLogger_Tests.cls
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ private class CallableLogger_Tests {

System.Assert.areEqual(2, returnedOutput.size());
System.Assert.areEqual(false, returnedOutput.get('isSuccess'), 'Expected isSuccess == false. Output received: ' + returnedOutput);
System.Assert.areEqual('Unsupported action: ' + fakeActionName, returnedOutput.get('errorMessage'));
System.Assert.areEqual('Unknown action: ' + fakeActionName, returnedOutput.get('errorMessage'));
}

@IsTest
Expand All @@ -28,7 +28,22 @@ private class CallableLogger_Tests {

System.Assert.areEqual(2, omnistudioOutput.size());
System.Assert.areEqual(false, omnistudioOutput.get('isSuccess'), 'Expected isSuccess == false. Output received: ' + omnistudioOutput);
System.Assert.areEqual('Unsupported action: ' + fakeActionName, omnistudioOutput.get('errorMessage'));
System.Assert.areEqual('Unknown action: ' + fakeActionName, omnistudioOutput.get('errorMessage'));
}

@IsTest
static void it_requires_case_sensitive_string_values_for_action_name() {
// The specific action being tested here (setParentLogTransactionId()) isn't really important - it could be any supported action.
// What _is_ important is verifying that the action name is case-sensitive.
String correctlyCasedActionName = 'getParentLogTransactionId';
String incorrectlyCasedActionName = correctlyCasedActionName.toUpperCase();

System.Callable callableLoggerInstance = (System.Callable) System.Type.forName('CallableLogger').newInstance();
Map<String, Object> returnedOutput = (Map<String, Object>) callableLoggerInstance.call(incorrectlyCasedActionName, null);

System.Assert.areEqual(2, returnedOutput.size());
System.Assert.areEqual(false, returnedOutput.get('isSuccess'), 'Expected isSuccess == false. Output received: ' + returnedOutput);
System.Assert.areEqual('Unknown action: ' + incorrectlyCasedActionName, returnedOutput.get('errorMessage'));
}

@IsTest
Expand Down Expand Up @@ -107,7 +122,7 @@ private class CallableLogger_Tests {
Map<String, Object> omnistudioOutput = new Map<String, Object>();

System.Callable callableLoggerInstance = (System.Callable) System.Type.forName('CallableLogger').newInstance();
callableLoggerInstance.call('setParentLogTransactionId', new Map<String, Object>{ 'input' => omnistudioInput, 'returnedOutput' => omnistudioOutput });
callableLoggerInstance.call('setParentLogTransactionId', new Map<String, Object>{ 'input' => omnistudioInput, 'output' => omnistudioOutput });

System.Assert.areEqual(1, omnistudioOutput.size());
System.Assert.areEqual(true, omnistudioOutput.get('isSuccess'), 'Expected isSuccess == true. Output received: ' + omnistudioOutput);
Expand Down Expand Up @@ -349,6 +364,7 @@ private class CallableLogger_Tests {

@IsTest
static void it_adds_new_entry_when_using_omnistudio_approach() {
// TODO revisit / delete?
String loggingLevelName = System.LoggingLevel.FINE.name();
String message = 'some log entry message';
Map<String, Object> omnistudioInput = new Map<String, Object>{ 'loggingLevel' => loggingLevelName, 'message' => message };
Expand All @@ -364,36 +380,69 @@ private class CallableLogger_Tests {
}

@IsTest
static void it_saves_log_without_specifying_a_save_method() {
static void it_saves_log_without_specifying_a_save_method_when_using_standard_approach() {
Logger.info('some log entry that will be saved using the default save method').getLogEntryEvent();
System.Assert.areEqual(1, Logger.getBufferSize());
System.Assert.isNull(Logger.lastSaveMethodNameUsed);

System.Callable callableLoggerInstance = (System.Callable) System.Type.forName('CallableLogger').newInstance();
Object returnedValue = callableLoggerInstance.call('saveLog', null);
Map<String, Object> returnedOutput = (Map<String, Object>) callableLoggerInstance.call('saveLog', null);

System.Assert.isNull(returnedValue, 'No return value expected for Logger.saveLog(), received ' + returnedValue);
System.Assert.areEqual(0, Logger.getBufferSize());
System.Assert.areEqual(1, returnedOutput.size());
System.Assert.areEqual(true, returnedOutput.get('isSuccess'), 'Expected isSuccess == true. Output received: ' + returnedOutput);
System.Assert.areEqual(Logger.getUserSettings().DefaultSaveMethod__c, Logger.lastSaveMethodNameUsed);
}

@IsTest
static void it_saves_log_with_specified_save_method() {
static void it_saves_log_without_specifying_a_save_method_when_using_omnistudio_approach() {
Logger.info('some log entry that will be saved using the default save method').getLogEntryEvent();
System.Assert.areEqual(1, Logger.getBufferSize());
System.Assert.isNull(Logger.lastSaveMethodNameUsed);
Map<String, Object> omnistudioOutput = new Map<String, Object>();

System.Callable callableLoggerInstance = (System.Callable) System.Type.forName('CallableLogger').newInstance();
callableLoggerInstance.call('saveLog', new Map<String, Object>{ 'output' => omnistudioOutput });

System.Assert.areEqual(1, omnistudioOutput.size(), omnistudioOutput.toString());
System.Assert.areEqual(true, omnistudioOutput.get('isSuccess'), 'Expected isSuccess == true. Output received: ' + omnistudioOutput);
System.Assert.areEqual(Logger.getUserSettings().DefaultSaveMethod__c, Logger.lastSaveMethodNameUsed);
}

@IsTest
static void it_saves_log_with_specified_save_method_when_using_standard_approach() {
Logger.info('some log entry that will be saved using the specified save method').getLogEntryEvent();
System.Assert.areEqual(1, Logger.getBufferSize());
System.Assert.isNull(Logger.lastSaveMethodNameUsed);
String targetSaveMethodName = Logger.SaveMethod.SYNCHRONOUS_DML.name();

System.Callable callableLoggerInstance = (System.Callable) System.Type.forName('CallableLogger').newInstance();
Object returnedValue = callableLoggerInstance.call('saveLog', new Map<String, Object>{ 'saveMethodName' => targetSaveMethodName });
Map<String, Object> returnedOutput = (Map<String, Object>) callableLoggerInstance.call('saveLog', new Map<String, Object>{ 'saveMethodName' => targetSaveMethodName });

System.Assert.isNull(returnedValue, 'No return value expected for Logger.saveLog(), received ' + returnedValue);
System.Assert.areEqual(1, returnedOutput.size());
System.Assert.areEqual(true, returnedOutput.get('isSuccess'), 'Expected isSuccess == true. Output received: ' + returnedOutput);
System.Assert.areEqual(0, Logger.getBufferSize());
System.Assert.areEqual(targetSaveMethodName, Logger.lastSaveMethodNameUsed);
}

@IsTest
static void it_saves_log_with_specified_save_method_when_using_omnistudio_approach() {
Logger.info('some log entry that will be saved using the specified save method').getLogEntryEvent();
System.Assert.areEqual(1, Logger.getBufferSize());
System.Assert.isNull(Logger.lastSaveMethodNameUsed);
String targetSaveMethodName = Logger.SaveMethod.SYNCHRONOUS_DML.name();

System.Callable callableLoggerInstance = (System.Callable) System.Type.forName('CallableLogger').newInstance();
Map<String, Object> returnedOutput = (Map<String, Object>) callableLoggerInstance.call('saveLog', new Map<String, Object>{ 'saveMethodName' => targetSaveMethodName });

System.Assert.areEqual(1, returnedOutput.size());
System.Assert.areEqual(true, returnedOutput.get('isSuccess'), 'Expected isSuccess == true. Output received: ' + returnedOutput);
System.Assert.areEqual(0, Logger.getBufferSize());
System.Assert.areEqual(targetSaveMethodName, Logger.lastSaveMethodNameUsed);
}

@IsTest
static void it_adds_and_saves_new_entry_when_using_omnistudio_approach() {
// TODO revisit / delete?
System.Assert.isNull(Logger.lastSaveMethodNameUsed);
String loggingLevelName = System.LoggingLevel.FINE.name();
String message = 'some log entry message';
Expand All @@ -406,19 +455,4 @@ private class CallableLogger_Tests {
System.Assert.areEqual(0, Logger.getBufferSize());
System.Assert.areEqual(Logger.getUserSettings().DefaultSaveMethod__c, Logger.lastSaveMethodNameUsed);
}

@IsTest
static void it_supports_case_insensitive_strings_for_action_and_argument_names() {
// The specific action being tested here (setParentLogTransactionId()) isn't really important - it could be any supported action.
// What _is_ important is verifying that both the action name & argument names are not case-sensitive.
System.Assert.isNull(Logger.getParentLogTransactionId(), 'Test has started under the wrong conditions');
String mockParentLogTransactionId = 'some transaction id';

System.Callable callableLoggerInstance = (System.Callable) System.Type.forName('CallableLogger').newInstance();
Object returnedValue = callableLoggerInstance
.call('SeTpArEnTlOgTrAnSaCtIoNiD', new Map<String, Object>{ 'PARENTlogTRANSACTIONiD' => mockParentLogTransactionId });

System.Assert.isNull(returnedValue, 'No return value expected for Logger.getParentLogTransactionId(), received ' + returnedValue);
System.Assert.areEqual(mockParentLogTransactionId, Logger.getParentLogTransactionId());
}
}

0 comments on commit ca46021

Please sign in to comment.