[WIP]

jongpie · Sep 15, 2024 · abdb053 · abdb053
1 parent 219e743
commit abdb053
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 54 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -8,41 +8,14 @@ env:
 
 on:
   push:
-    branches:
-      - main
-      - 'feature/callable-logger'
-    paths-ignore:
-      - 'content/**'
-      - 'docs/**'
-      - 'examples/**'
-      - 'packages/**'
-      - '.forceignore'
-      - '.gitignore'
-      - '.prettierignore'
-      - '.prettierrc'
-      - 'CONTRIBUTING.md'
-      - 'LICENSE'
-      - 'package.json'
-      - 'README.md'
-      - './**/README.md'
-      - 'sfdx-project.json'
+    paths:
+      - core/scratch-orgs/**
+      - nebula-logger/**
   pull_request:
     types: [opened, synchronize, reopened]
-    paths-ignore:
-      - 'content/**'
-      - 'docs/**'
-      - 'examples/**'
-      - 'packages/**'
-      - '.forceignore'
-      - '.gitignore'
-      - '.prettierignore'
-      - '.prettierrc'
-      - 'CONTRIBUTING.md'
-      - 'LICENSE'
-      - 'package.json'
-      - 'README.md'
-      - './**/README.md'
-      - 'sfdx-project.json'
+    paths:
+      - core/scratch-orgs/**
+      - nebula-logger/**
 
 jobs:
   code-quality-tests:
@@ -66,8 +39,16 @@ jobs:
         if: steps.cache-npm.outputs.cache-hit != 'true'
         run: npm ci
 
+      - name: 'Check for changes in core directory'
+        uses: dorny/paths-filter@v3
+        id: changes
+        with:
+          filters: |
+            core:
+              - './nebula-logger/core/**'
+
       - name: 'Authorize Dev Hub'
-        if: ${{ github.event_name == 'pull_request' }}
+        if: ${{ (github.event_name == 'pull_request') && (steps.changes.outputs.core == 'true') }}
         shell: bash
         run: |
           npx sf version
@@ -80,7 +61,7 @@ jobs:
           DEV_HUB_JWT_SERVER_KEY: ${{ secrets.DEV_HUB_JWT_SERVER_KEY }}
 
       - name: 'Verify package version number is updated'
-        if: ${{ github.event_name == 'pull_request' }}
+        if: ${{ (github.event_name == 'pull_request') && (steps.changes.outputs.core == 'true') }}
         run: npm run package:version:number:verify
 
       - name: 'Verify LWC with ESLint'

diff --git a/.mob b/.mob
diff --git a/nebula-logger/core/main/log-management/classes/LogEntryHandler.cls b/nebula-logger/core/main/log-management/classes/LogEntryHandler.cls
@@ -221,13 +221,6 @@ public without sharing class LogEntryHandler extends LoggerSObjectHandler {
   }
 
   private void setOmniProcessFields() {
-    // TODO consider overriding some fields like to be OmniStudio specific:
-    // - OriginType__c
-    // - OriginLocation__c
-    // - OriginSourceApiName__c
-    // - OriginSourceMetadataType__c
-    // etc....
-    // TODO need to figure if/when to query, and if strongly-typed references are available in all orgs (if not, new Proxy?)
     List<String> omniProcessIds = new List<String>();
     List<LogEntry__c> omniProcessLogEntries = new List<LogEntry__c>();
     for (LogEntry__c logEntry : this.logEntries) {

diff --git a/nebula-logger/core/tests/log-management/classes/LogEntryHandler_Tests.cls b/nebula-logger/core/tests/log-management/classes/LogEntryHandler_Tests.cls
@@ -1299,7 +1299,8 @@ private class LogEntryHandler_Tests {
         OriginSourceId__c,
         OriginSourceLastModifiedById__c,
         OriginSourceLastModifiedByUsername__c,
-        OriginSourceLastModifiedDate__c
+        OriginSourceLastModifiedDate__c,
+        OriginType__c
       FROM LogEntry__c
       WHERE Id = :logEntry.Id
     ];