Add support for pnpm 9 #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinvw1
commented
Aug 22, 2024
Comment on lines
+59
to
+68
| - uses: actions/github-script@v7 | ||
| id: calculate_architecture | ||
| with: | ||
| result-encoding: string | ||
| script: | | ||
| if ('${{ matrix.os }}' === 'macos-latest' && ['10', '12', '14'].includes('${{ matrix.node }}')) { | ||
| return "x64" | ||
| } else { | ||
| return '' | ||
| } |
There was a problem hiding this comment.
Some context:
- macos-latest now runs on ARM chips macos 14 is only arm64 actions/runner-images#9741 (comment).
- no ARM version for node 10, 12, 14 is available, also see Attempting to download... Not found in manifest. Falling back to download directly from Node actions/setup-node#1017 (comment).
So we fallback to x64 on those versions.
Step is copied from webpack: webpack/webpack#18359
|
@jonathanmorley any time to review this? |
|
Thanks for merging @jonathanmorley. 🫶 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After adding support for pnpm 8, I'm now adding support for pnpm 9.
pnpm 9 was released this Apr 16: https://github.com/pnpm/pnpm/releases/tag/v9.0.0
They dropped support for Node.js 16, so I've updated the matrix. Also fixed the CI that was failing.