Add ignore-prefix option to no-object-mutation rule #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the branch where there are multiple ignore-prefix is not covered by the tests, that's why coveralls complains. However this should not be a problem so I will go ahead and merge anyway :-). |
|
And yes, you are right about the readonly-shared module. I will go ahead and refactor that for better re-usability when I get some spare time. Thanks for the contribution :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option for ignoring object mutation by prefix. Partially addresses #43.
Feels like the option parsing and isIgnored checks want a shared module like readonly-shared to avoid duplication, but made them their own thing for now to avoid affecting other rules.