Added index signature fixer error case. (#63)

Fixes #62
jonaskello · Jan 16, 2018 · 7e4b593 · 7e4b593
1 parent 8db42f4
commit 7e4b593
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 8 deletions.
diff --git a/src/readonlyKeywordRule.ts b/src/readonlyKeywordRule.ts
@@ -50,17 +50,10 @@ function checkPropertySignatureAndIndexSignature(
       if (Ignore.shouldIgnorePrefix(node, ctx.options, ctx.sourceFile)) {
         return [];
       }
-      const length = node.getWidth(ctx.sourceFile);
-      // const fulltext = node.getText(ctx.sourceFile);
-      const fulltext = node.getText(ctx.sourceFile);
       return [
         createInvalidNode(
           node,
-          new Lint.Replacement(
-            node.end - length,
-            length,
-            `readonly ${fulltext}`
-          )
+          new Lint.Replacement(node.getStart(ctx.sourceFile), 0, "readonly ")
         )
       ];
     }

diff --git a/test/rules/readonly-keyword/default/index-signature.ts.fix b/test/rules/readonly-keyword/default/index-signature.ts.fix
@@ -0,0 +1,17 @@
+
+// Index signature as part of interface
+interface Foo {
+  readonly [key: string]: string
+}
+
+// Index signature as return value from function
+
+function foo(): { readonly [source: string]: string } {
+  return undefined;
+}
+
+// Index signature with nested object.
+interface Foo {
+  readonly [key: string]: { readonly bar: string }
+}
+
diff --git a/test/rules/readonly-keyword/default/index-signature.ts.lint b/test/rules/readonly-keyword/default/index-signature.ts.lint
@@ -12,4 +12,11 @@ function foo(): { [source: string]: string } {
   return undefined;
 }
 
+// Index signature with nested object.
+interface Foo {
+  [key: string]: { bar: string }
+  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~   [failure]
+                   ~~~~~~~~~~~ [failure]
+}
+
 [failure]: A readonly modifier is required.