Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keybind with +[cmd] not triggering view refreshing #1324

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions src/display.c
Original file line number Diff line number Diff line change
Expand Up @@ -73,16 +73,13 @@ open_external_viewer(const char *argv[], const char *dir, bool silent, bool conf
bool ok;

if (echo) {
struct io io;
char buf[SIZEOF_STR] = "";

io_run_buf(argv, buf, sizeof(buf), dir, false);
if (*buf) {
ok = io_exec(&io, IO_RD, dir, NULL, argv, IO_RD_WITH_STDERR) && io_read_buf(&io, buf, sizeof(buf), true);
if (*buf)
report("%s", buf);
return true;
} else {
report("No output");
return false;
}

} else if (silent || is_script_executing()) {
ok = io_run_bg(argv, dir);

Expand Down
5 changes: 3 additions & 2 deletions src/view.c
Original file line number Diff line number Diff line change
Expand Up @@ -851,9 +851,10 @@ load_view(struct view *view, struct view *prev, enum open_flags flags)
* the screen. */
werase(view->win);
/* Do not clear the position if it is the first view. */
if (view->prev && !(flags & (OPEN_RELOAD | OPEN_REFRESH)))
if (view->prev && !(flags & (OPEN_RELOAD | OPEN_REFRESH))) {
clear_position(&view->prev_pos);
report_clear();
report_clear();
}
} else if (view_is_displayed(view)) {
redraw_view(view);
report_clear();
Expand Down