Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should default to "line_graphics = utf-8" if supported #834

Closed
proski opened this issue May 25, 2018 · 1 comment · Fixed by #1019
Closed

Should default to "line_graphics = utf-8" if supported #834

proski opened this issue May 25, 2018 · 1 comment · Fixed by #1019

Comments

@proski
Copy link
Contributor

proski commented May 25, 2018

I've been using tig for years, yet I only discovered "line_graphics = utf-8" recently by finding references to it accidentally in the tig's own commit history. It's a beautiful feature, I wish I new of it earlier.

I believe "line_graphics = utf-8" should be default. If UTF-8 is unsupported, an ASCII approximation should be used. I see that tig uses ? for graphics in the C locale - that's not a good approximation (I'm not sure if tig or ncurses does it).

Another approach would be to have a new option "line_graphics = auto" as the default. It would select the graphics based on the terminal and locale. "line_graphics = utf-8" would force the UTF-8 graphics.

@jonas
Copy link
Owner

jonas commented May 25, 2018

I prefer to introduce an auto value.

koutcher added a commit to koutcher/tig that referenced this issue Jun 21, 2020
koutcher added a commit to koutcher/tig that referenced this issue Oct 13, 2020
koutcher added a commit to koutcher/tig that referenced this issue Dec 13, 2020
koutcher added a commit that referenced this issue Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants