Correctly report allocation failure in argv_append

jonas · Aug 23, 2012 · e35b50d · e35b50d
1 parent 9df8039
commit e35b50d
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/io.c b/io.c
@@ -113,16 +113,20 @@ bool
 argv_append(const char ***argv, const char *arg)
 {
 	size_t argc = argv_size(*argv);
+	char *alloc;
 
 	if (!*arg && argc > 0)
 		return TRUE;
 
 	if (!argv_realloc(argv, argc, 2))
 		return FALSE;
 
-	(*argv)[argc++] = strdup(arg);
+	alloc = strdup(arg);
+
+	(*argv)[argc++] = alloc;
 	(*argv)[argc] = NULL;
-	return TRUE;
+
+	return alloc != NULL;
 }
 
 bool