what a stupid bug! (giampaolo#1190)

jomann09 · Dec 7, 2017 · 090ae20 · 090ae20
1 parent a406eb0
commit 090ae20
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/HISTORY.rst b/HISTORY.rst
@@ -1,5 +1,14 @@
 *Bug tracker at https://github.com/giampaolo/psutil/issues*
 
+5.4.3
+=====
+
+*XXXX-XX-XX*
+
+**Bug fixes**
+
+- 1193_: pids() may return False on OSX.
+
 5.4.2
 =====
 

diff --git a/psutil/__init__.py b/psutil/__init__.py
@@ -219,7 +219,7 @@
 ]
 __all__.extend(_psplatform.__extra__all__)
 __author__ = "Giampaolo Rodola'"
-__version__ = "5.4.2"
+__version__ = "5.4.3"
 version_info = tuple([int(num) for num in __version__.split('.')])
 AF_LINK = _psplatform.AF_LINK
 POWER_TIME_UNLIMITED = _common.POWER_TIME_UNLIMITED

diff --git a/psutil/_psosx.py b/psutil/_psosx.py
@@ -309,12 +309,11 @@ def pids():
         # https://travis-ci.org/giampaolo/psutil/jobs/309619941
         try:
             Process(0).create_time()
+            ls.append(0)
         except NoSuchProcess:
-            return False
+            pass
         except AccessDenied:
             ls.append(0)
-        else:
-            ls.append(0)
     return ls