Cancel download throw error bugfix (Android) #381
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #363
In which @minextu wrote:
Basically he found a working PR that was put up against the old
wkh237
repo but was obviously out of date.PR #363 has a couple of unnecessary commits attached to it so I've simply took the only commit that actually fixes the problem and made a new PR with that.
Tested this against iOS and Android and now both platform are throwing a catchable Error whenever you call
.cancel()
on fetch request as the documentation says it should@Traviskn Can you review/merge this in when you get a chance, pretty harmless PR that fixes an old problem.
For anyone needing this functionality point to this repo/branch:
until this PR has been merged