Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs should be optional in walkSync.Options #60

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

kturney
Copy link
Contributor

@kturney kturney commented Oct 1, 2020

Ran into the walkSync.Options taken by this.input.entries in a broccoli plugin now saying that fs is required if an options object is provided.

example of what stopped working:

const sources = this.input
      .entries('.', {
        directories: false,
        globs: this.themeInputs.map((dir) => `${dir}/*.json`),
      })
      .map((entry) => entry.fullPath);

now gets error:

error TS2345: Argument of type '{ directories: false; globs: string[]; }' is not assignable to parameter of type 'Options'.
  Property 'fs' is missing in type '{ directories: false; globs: string[]; }' but required in type 'Options'.

33       .entries('.', {
                       ~
34         directories: false,
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~
35         globs: this.themeInputs.map((dir) => `${dir}/*.json`),
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
36       })
   ~~~~~~~

@kturney
Copy link
Contributor Author

kturney commented Nov 20, 2020

Any chance of getting this merged and published?

@kturney
Copy link
Contributor Author

kturney commented Mar 27, 2021

Hi all, any updates I can provide here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants