feat(loader): lock load class on file loader to avoid race condition #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelwurtz
force-pushed
the
feat/lock-load-class
branch
from
3494fea
to
e1b0fe4
Compare
Korbeil
reviewed
Jul 16, 2024
| @@ -40,25 +42,33 @@ public function loadClass(MapperMetadata $mapperMetadata): void | |||
| $className = $mapperMetadata->className; | |||
| $classPath = $this->directory . \DIRECTORY_SEPARATOR . $className . '.php'; | |||
|
|
|||
| if ($this->reloadStrategy === FileReloadStrategy::NEVER && file_exists($classPath)) { | |||
| require $classPath; | |||
| // We lock the file here, because another process could be writing the file at the same time | |||
There was a problem hiding this comment.
Shouldn't we wait until the other process is done (waiting on lock release) until returning this method ?
So we are sure the file is generated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There can be race condition when multiple php process would generate the class at the same time, so we add a lock here to avoid this problem
Better diff with
?w=1