Task/jabertuhin/1517/add datetime provider for bd #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcurella
requested changes
Sep 24, 2021
| from .. import Provider as DateTimeProvider | ||
|
|
||
|
|
||
| class Provider(DateTimeProvider): |
There was a problem hiding this comment.
There's some extra space at the end of this line that's making the linter fail. Could you remove it?
Suggested change
| class Provider(DateTimeProvider): | |
| class Provider(DateTimeProvider): |
There was a problem hiding this comment.
Thanks for the feedback. I have updated my pull-request.
…ttps://github.com/jabertuhin/faker into task/jabertuhin/1517/add-datetime-provider-for-bd
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this changes
This pull-request addresses issue #1517 . I have created new
bn_BDpackage under date_time package.What was wrong
N/A
How this fixes it
N/A
Fixes #...
N/A