Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finnish states uses old regional division #1458

Closed
LKajan opened this issue Jun 11, 2021 · 0 comments · Fixed by #1459
Closed

Finnish states uses old regional division #1458

LKajan opened this issue Jun 11, 2021 · 0 comments · Fixed by #1459

Comments

@LKajan
Copy link
Contributor

LKajan commented Jun 11, 2021

  • Faker version: 8.6.0
  • OS: all

Finnish localized Address provider uses old provinces (Lääni) as states which were abolished in 2009. In Finland current division should use regions (Maakunta). https://www.stat.fi/fi/luokitukset/maakunta/maakunta_1_20210101/

Steps to reproduce

>>> from faker import Faker
>>> fake = Faker('fi_FI')
>>> fake.state()
'Vaasan lääni'

Expected behavior

fake.state() should return a random Region

Actual behavior

fake.state() returns a random Province that were abolished in 2009
LKajan added a commit to LKajan/faker that referenced this issue Jun 11, 2021
@LKajan
Fix joke2k#1458. Change fi_FI Provinces to Regions
02a9710 
Finnish Provinces were abolished in 2009. Use current Regions
as administrative units.
@LKajan LKajan mentioned this issue Jun 11, 2021
Merged
LKajan added a commit to LKajan/faker that referenced this issue Jun 11, 2021
@LKajan
Fix joke2k#1458. Change fi_FI Provinces to Regions
3ae3178 
Finnish Provinces were abolished in 2009. Use current Regions
as administrative units.
fcurella added a commit that referenced this issue Sep 15, 2021
@LKajan @fcurella
Fix #1458. Change fi_FI Provinces to Regions (#1459)
54a0d7a 
* Fix #1458. Change fi_FI Provinces to Regions

Finnish Provinces were abolished in 2009. Use current Regions
as administrative units.

* Add trailing comma

Co-authored-by: Flavio Curella <[email protected]>

Co-authored-by: Flavio Curella <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1458. Change fi_FI Provinces to Regions LKajan/faker
1 participant
@LKajan