Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve environment variable values #433

Closed
wants to merge 3 commits into from
Closed

Conversation

invasy
Copy link
Contributor

@invasy invasy commented Jan 8, 2023

Fix #421: add support for embedded variables.

  • Substitute environment variable values mentioned as $VAR or ${VAR}.
  • Detect self-referenced variables (infinite recursion).

Fix joke2k#421: add support for embedded variables.
@sergeyklay sergeyklay added the enhancement New feature or request label Mar 1, 2023
@invasy invasy force-pushed the main branch 4 times, most recently from 6b62edc to 9f56294 Compare April 12, 2023 15:48
@coveralls
Copy link

coveralls commented Apr 20, 2023

Coverage Status

Coverage: 91.956% (+0.3%) from 91.635% when pulling 5897705 on invasy:main into 8874288 on joke2k:main.

Copy link
Collaborator

@sergeyklay sergeyklay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution to django-environ. Your code looks good and is in line with the project's philosophy. I am ready to accept your changes, however, there are a few things that need to be done before I can do so:

Add documentation for the new feature: This is a very important aspect for the users of this project. Please ensure that you've added detailed information on how to use the new feature, including examples and possible use cases.

Update the changelog: This will help the community stay informed about the changes happening in the project. Please add information about your new feature and how it affects the current functionality of the project.

After completing these two items, I'll be more than happy to accept your Pull Request. If you have any questions or need assistance, please feel free to reach out.

Finally, send this PR to develop branch, not main.

Thank you for your collaboration and efforts in improving django-environ!

@invasy
Copy link
Contributor Author

invasy commented Apr 24, 2023

Closed in favor of pull request #468 with fixed issues.

@invasy invasy closed this Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any plan to support embedded variables?
3 participants