Torrents! #40
Torrents! #40
Conversation
If the newest zim and torrent both existed, would give strange message
|
@jojo2357 I've looked through the README, and it seems well worded and accurate. I didn't see anything I would want to change. Thanks! |
|
Does purging work as intended? Right now iirc t mode does no such thing, but the standard version does still purge. This could be a problem, or if the user is advanced enough we hope they know whether or not they want to keep old versions. |
-t mode doesn't understand -p (and I think that's correct, -t mode should never purge, and so -p is redundant). I'm going on having done a dry-run with and without -p and noticing that the outcome would have been the same, and different from doing the same without -t. But in terms of a "live run", I ran it with -p. I didn't quite dare run it without, even though the dry-run had indicated it would be safe! I have a lot of old ZIMs I use for testing / development on Kiwix, and I don't want to lose them. So I would strongly urge against introducing a purge function in -t mode. |
|
works for me. if you torrent then you should remove the torrent and the zim With @DocDrydenn 's blessing, I will hit that merge button. I will give it about a day for any other comments. |
There was a problem hiding this comment.
Hello all!
Just wanted to give a quick update. My homelab has been undergoing upgrades (racking changes, storage upgrades, and a full network overhaul) for about the last two weeks... and I've been unable to physically test the scrip updates against my ZIM library.
That said, I don't let me be the reason this merge gets held up. I gave the changes a look and didn't see anything that looks to be a problem. Knowing that you all have tested, I say Go.
|
Well we have the |
closes #35
Changelog: