Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve identity deletion #678

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

alphatownsman
Copy link
Contributor

@alphatownsman alphatownsman commented Dec 12, 2023

  • disable all current login tokens
  • ignore new mention
  • ignore new follow
  • delete all data
  • fanout delete posts, interactions
  • fanout unfollow both directions
  • fanout nullified identity, then fanout delete identity
  • keep nullified identity for 7 days then delete forever


if not instance.local:
return cls.updated

# Delete local data including logins
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This says "including logins" but it does not seem to (and I would not want it to as that's on the User level) - is this an outdated comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, outdated. just fixed.

@andrewgodwin
Copy link
Member

Great - get the lint failures passing (just run pip install pre-commit; pre-commit run -a locally if you've not installed the hooks yet) and I think we can merge this in.

@alphatownsman
Copy link
Contributor Author

done.

@andrewgodwin andrewgodwin merged commit 448092d into jointakahe:main Dec 16, 2023
3 checks passed
@andrewgodwin
Copy link
Member

Thanks!

@alphatownsman alphatownsman deleted the identity-delete branch January 14, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants