ObjectsLab #105
Open
ObjectsLab #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const appleCount = () => {}; | ||
|
|
||
| const appleCount = (appleCountByName, name) => { | ||
| if(!appleCountByName[name]){ |
There was a problem hiding this comment.
can we do:
return appleCountByName[name] || 0
How does this work?
| const adamAndEveApples = () => {}; | ||
| // let names = {"Adam": 2, "Eve": 5} | ||
| const adamAndEveApples = (appleCountByName) => { | ||
| let sum = 0 |
There was a problem hiding this comment.
We don't need this sum variable. Too much work and not helping us. Just return appleCountByName.Adam + appleCountByName.Eve
| const appleSum = () => {}; | ||
| const appleSum = (appleCountByName, number) => { | ||
| let sum = 0 | ||
| sum = appleCountByName |
There was a problem hiding this comment.
appleCountByName is an object. Make sure you think about things in terms of types of data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incomplete as I did what I could with help of Obi