Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: 2024.6.0 #36

Merged
merged 11 commits into from
May 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions .github/workflows/merge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,20 @@ jobs:
uses: joinmisskey/release-actions/.github/actions/get-target-version@main
id: v

- uses: actions/create-github-app-token@v1
id: release-app-token
if: inputs.use_external_app_to_release
with:
app-id: ${{ secrets.RELEASE_APP_ID }}
private-key: ${{ secrets.RELEASE_APP_PRIVATE_KEY }}

# mergeable: UNKNOWNを回避したい
- name: 'Pre-fetch PR data'
run: |
gh pr view "$PR_NUMBER" --json mergeable
env:
PR_NUMBER: ${{ inputs.pr_number }}
GITHUB_TOKEN: ${{ inputs.use_external_app_to_release && steps.release-app-token.outputs.token || secrets.GITHUB_TOKEN }}
- name: Sleep
run: sleep 5s

Expand All @@ -77,6 +85,7 @@ jobs:
echo "data=$(gh pr view "$PR_NUMBER" --json baseRefName,reviewDecision,isDraft,mergeStateStatus,statusCheckRollup,mergeable)" >> $GITHUB_OUTPUT
env:
PR_NUMBER: ${{ inputs.pr_number }}
GITHUB_TOKEN: ${{ inputs.use_external_app_to_release && steps.release-app-token.outputs.token || secrets.GITHUB_TOKEN }}
- name: 'Check Mergeable: compare'
uses: actions/script@v7
env:
Expand All @@ -88,12 +97,12 @@ jobs:
throw new Error('PR is draft');
}
if (pr.reviewDecision !== 'APPROVED') {
throw new Error(`reviewDecision is not APPROVED: ${pr.reviewDecision}`);
throw new Error(`reviewDecision is not APPROVED (${pr.reviewDecision}). You must approve the PR before merging.`);
}
if (pr.mergeable !== 'MERGEABLE') {
throw new Error(`Not mergeable: ${pr.mergeable}`);
}
if (pr.mergeStateStatus !== 'CLEAN') {
if (pr.mergeStateStatus !== 'CLEAN' && pr.mergeStateStatus !== 'BLOCKED') {
throw new Error(`MergeStateStatus is not CLEAN: ${pr.mergeStateStatus}`);
}
if (pr.statusCheckRollup.find(s => s.conclusion !== 'SUCCESS')) {
Expand Down Expand Up @@ -132,12 +141,6 @@ jobs:
TARGET_VERSION: ${{ steps.v.outputs.target_version }}

# リリースを作成
- uses: actions/create-github-app-token@v1
id: release-app-token
if: inputs.use_external_app_to_release
with:
app-id: ${{ secrets.RELEASE_APP_ID }}
private-key: ${{ secrets.RELEASE_APP_PRIVATE_KEY }}
- name: Create release
env:
GITHUB_TOKEN: ${{ inputs.use_external_app_to_release && steps.release-app-token.outputs.token || secrets.GITHUB_TOKEN }}
Expand All @@ -152,12 +155,13 @@ jobs:
uses: prichey/retry@c92c7ba2f5f4d0b3b7b2b04cc5c6672f9c884a3f
with:
command: |
gh pr merge "$PR_NUMBER" --merge
gh pr merge "$PR_NUMBER" --merge --admin
timeout_seconds: 30
max_attempts: 3
retry_wait_seconds: 5
env:
PR_NUMBER: ${{ inputs.pr_number }}
GITHUB_TOKEN: ${{ inputs.use_external_app_to_release && steps.release-app-token.outputs.token || secrets.GITHUB_TOKEN }}

# CHANGELOG.mdにUnreleasedのテンプレートを追加
- name: Prepend CHANGELOG template
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-edit-with-push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: "Release Manager: sync changelog with PR"
on:
push:
branches:
- develop
- main
paths:
- 'CHANGELOG.md'

Expand Down
13 changes: 13 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,19 @@
CHANGELOG
=======================================

## 2024.6.0

### General
- test
- test2

### Client
-

### Server
-


## 2024.5.6

### General
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"name": "sandbox-actions-release",
"version": "2024.5.8"
"version": "2024.6.0"
}
2 changes: 1 addition & 1 deletion packages/misskey-js/package.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"name": "sandbox-actions-release-misskey-js",
"version": "2024.5.8"
"version": "2024.6.0"
}