Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opinionated bug fixes #94

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Opinionated bug fixes #94

wants to merge 19 commits into from

Commits on Oct 13, 2019

  1. fix implicit global variables

    @wmakley
    wmakley committed Oct 13, 2019
    Configuration menu
    Copy the full SHA
    50dbbce View commit details
    Browse the repository at this point in the history

  2. avoid variable re-declaration 

    May be controversial. I would use the original style with let and const,
not with var.
    @wmakley
    wmakley committed Oct 13, 2019
    Configuration menu
    Copy the full SHA
    ab6cb21 View commit details
    Browse the repository at this point in the history

  3. shift does not take any arguments

    @wmakley
    wmakley committed Oct 13, 2019
    Configuration menu
    Copy the full SHA
    33e2dd2 View commit details
    Browse the repository at this point in the history

  4. fix more implicit variable re-declaration

    @wmakley
    wmakley committed Oct 13, 2019
    Configuration menu
    Copy the full SHA
    ad971bc View commit details
    Browse the repository at this point in the history

  5. fix typo

    @wmakley
    wmakley committed Oct 13, 2019
    Configuration menu
    Copy the full SHA
    4b9f3b7 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2019

  1. replace all == with === to avoid accidental type coercion

    @wmakley
    wmakley committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    c4c9114 View commit details
    Browse the repository at this point in the history

  2. zIndex property is a string, so let's be explicit about the type coer… 

    …cion that is going on
    @wmakley
    wmakley committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    fc5105d View commit details
    Browse the repository at this point in the history

  3. revert changes to some implicit globals that were actually supposed t… 

    …o be globals
    @wmakley
    wmakley committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    9edd8d1 View commit details
    Browse the repository at this point in the history

  4. remove unused variable

    @wmakley
    wmakley committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    1051795 View commit details
    Browse the repository at this point in the history

  5. declare 'found' variable (fix implicit global)

    @wmakley
    wmakley committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    6440e56 View commit details
    Browse the repository at this point in the history

  6. remove unnecessary semicolon

    @wmakley
    wmakley committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    a8c2fc1 View commit details
    Browse the repository at this point in the history

  7. remove redundant returns

    @wmakley
    wmakley committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    fb99491 View commit details
    Browse the repository at this point in the history

  8. fix another implicit global 'key' variable

    @wmakley
    wmakley committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    8e927e3 View commit details
    Browse the repository at this point in the history

  9. remove unnecessary commas

    @wmakley
    wmakley committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    567e63e View commit details
    Browse the repository at this point in the history

  10. remove unused variable

    @wmakley
    wmakley committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    173ce7a View commit details
    Browse the repository at this point in the history

  11. add comments to mystery ui variables

    @wmakley
    wmakley committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    a3fae43 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'minor-bug-fixes' into opinionated-bug-fixes

    @wmakley
    wmakley committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    5810a1f View commit details
    Browse the repository at this point in the history

  13. replace more == with ===

    @wmakley
    wmakley committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    6884f6f View commit details
    Browse the repository at this point in the history

  14. convert numbers to strings before assigning to string properties

    @wmakley
    wmakley committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    cadc2ac View commit details
    Browse the repository at this point in the history