Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to see if 2.12.14 just works with graalvm #737

Merged
merged 6 commits into from
Jun 5, 2021
Merged

Conversation

johnynek
Copy link
Owner

No description provided.

@johnynek
Copy link
Owner Author

after updating to graalvm to 21.1.0 in #736 I want to see if 2.12.14 just works (2.12.12 used method handles that tripped up native-image).

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2021

Codecov Report

Merging #737 (26920b3) into master (7ae857a) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #737      +/-   ##
==========================================
+ Coverage   91.94%   91.99%   +0.05%     
==========================================
  Files          82       82              
  Lines        7483     7483              
  Branches      330      330              
==========================================
+ Hits         6880     6884       +4     
+ Misses        603      599       -4     
Impacted Files Coverage Δ
...n/scala/org/bykn/bosatsu/codegen/python/Code.scala 94.47% <0.00%> (ø)
.../src/main/scala/org/bykn/bosatsu/Declaration.scala 98.96% <0.00%> (+0.20%) ⬆️
...re/src/main/scala/org/bykn/bosatsu/TypedExpr.scala 83.11% <0.00%> (+0.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ae857a...26920b3. Read the comment docs.

@johnynek
Copy link
Owner Author

okay, it doesn't "just work".

I guess I should use the sbt-native-image plugin which has a work around:

https://github.com/scalameta/sbt-native-image

@johnynek johnynek merged commit b1ab28d into master Jun 5, 2021
@johnynek johnynek deleted the oscar/do_2_12_14 branch June 5, 2021 21:46
@johnynek
Copy link
Owner Author

closes #558

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants