-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable incremental compilation in bazel rules #281
Conversation
Codecov Report
@@ Coverage Diff @@
## master #281 +/- ##
==========================================
- Coverage 86.83% 86.47% -0.37%
==========================================
Files 56 56
Lines 4536 4570 +34
Branches 181 195 +14
==========================================
+ Hits 3939 3952 +13
- Misses 597 618 +21
Continue to review full report at Codecov.
|
note, this coverage decline is actually false, we exercise the Main.scala code in the bazel rules, but we don't merge that coverage into the main reports. |
going to merge this when it goes green.... end of a long road. It's pretty great to have incremental compilation working! My next steps I think are:
|
The coverage issue is due to Main not having coverage in tests, but is tested by the bosatsu bazel rules. |
This uses the work in #54 to incrementally compile
bosatsu_library
and avoid typechecking dependencies for given targets. bosatsu_test now reuses the library parsing and typechecking.this uncovered the bugs in #279