Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serialization of TypedExpr to proto #266

Merged
merged 3 commits into from
May 27, 2019
Merged

Conversation

johnynek
Copy link
Owner

@johnynek johnynek commented May 26, 2019

part of #54

This adds conversion of TypedExpr to proto. Along the way, it also makes TypeExpr covariant.

@codecov-io
Copy link

codecov-io commented May 26, 2019

Codecov Report

Merging #266 into master will increase coverage by 0.1%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #266     +/-   ##
=========================================
+ Coverage   85.93%   86.04%   +0.1%     
=========================================
  Files          55       55             
  Lines        4082     4184    +102     
  Branches      171      179      +8     
=========================================
+ Hits         3508     3600     +92     
- Misses        574      584     +10
Impacted Files Coverage Δ
...re/src/main/scala/org/bykn/bosatsu/TypedExpr.scala 71.01% <60%> (+0.86%) ⬆️
...main/scala/org/bykn/bosatsu/TypedExprToProto.scala 87.52% <91.37%> (+1.06%) ⬆️
...e/src/main/scala/org/bykn/bosatsu/rankn/Type.scala 89.47% <0%> (-0.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c85d4c...7206fc2. Read the comment docs.

@johnynek johnynek merged commit 1e4380a into master May 27, 2019
@johnynek johnynek deleted the oscar/add_type_expr_proto branch May 27, 2019 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants