Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Proto version of package interfaces #252

Merged
merged 4 commits into from
May 16, 2019
Merged

Conversation

johnynek
Copy link
Owner

part of #54

This adds proto serialization of interfaces, but does not yet use them.

The idea is to allow the CLI to depend on proto interfaces and avoid having to transitively recompile code in order to use dependencies. We should also emit proto interfaces when we compile. Lastly, we need to make the bazel rules aware of these so it can plumb them through correctly. That will be in follow up PRs.

@codecov-io
Copy link

codecov-io commented May 15, 2019

Codecov Report

Merging #252 into master will decrease coverage by 0.37%.
The diff coverage is 72.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
- Coverage      86%   85.62%   -0.38%     
==========================================
  Files          55       55              
  Lines        3758     3890     +132     
  Branches      151      156       +5     
==========================================
+ Hits         3232     3331      +99     
- Misses        526      559      +33
Impacted Files Coverage Δ
...src/main/scala/org/bykn/bosatsu/ExportedName.scala 97.05% <ø> (ø) ⬆️
cli/src/main/scala/org/bykn/bosatsu/Main.scala 0% <0%> (ø) ⬆️
core/src/main/scala/org/bykn/bosatsu/Package.scala 98.38% <100%> (ø) ⬆️
...rc/main/scala/org/bykn/bosatsu/Normalization.scala 92.91% <100%> (ø) ⬆️
...e/src/main/scala/org/bykn/bosatsu/Identifier.scala 88.88% <100%> (+0.42%) ⬆️
...e/src/main/scala/org/bykn/bosatsu/Evaluation.scala 89.95% <100%> (ø) ⬆️
core/src/main/scala/org/bykn/bosatsu/Codegen.scala 63.55% <50%> (ø) ⬆️
...main/scala/org/bykn/bosatsu/TypedExprToProto.scala 79.45% <80.74%> (+1.19%) ⬆️
...e/src/main/scala/org/bykn/bosatsu/StringUtil.scala 96.66% <0%> (-1.67%) ⬇️
...rc/main/scala/org/bykn/bosatsu/TotalityCheck.scala 96.26% <0%> (-0.38%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc93062...39656a3. Read the comment docs.

@johnynek johnynek merged commit 14ae6fc into master May 16, 2019
@johnynek johnynek mentioned this pull request May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants