Add integer bitwise-and tests #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1283 +/- ##
==========================================
- Coverage 91.32% 89.33% -2.00%
==========================================
Files 96 106 +10
Lines 11846 13300 +1454
Branches 2675 3018 +343
==========================================
+ Hits 10818 11881 +1063
- Misses 1028 1419 +391 ☔ View full report in Codecov by Sentry. |
johnynek
commented
Nov 30, 2024
c_runtime/bosatsu_runtime.c
Outdated
| } else { | ||
| // Promote to big integer | ||
| _Bool is_positive = result >= 0; | ||
| uint64_t abs_result = result >= 0 ? result : -result; |
There was a problem hiding this comment.
Checking result >= 0 twice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.