run list tests #1278
Merged
run list tests #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1278 +/- ##
==========================================
- Coverage 91.32% 89.38% -1.94%
==========================================
Files 96 106 +10
Lines 11846 13299 +1453
Branches 2675 3043 +368
==========================================
+ Hits 10818 11887 +1069
- Misses 1028 1412 +384 ☔ View full report in Codecov by Sentry. |
johnynek
commented
Nov 28, 2024
c_runtime/bosatsu_runtime.c
Outdated
| while (slots > 0) { | ||
| release_value(items); | ||
| items = items + 1; | ||
| slots = slots - 1; | ||
| } | ||
| free(items0); |
There was a problem hiding this comment.
we don't need to do this... this memory was allocated in the same malloc as s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this runs the tests for the Bosatsu/List module using the generated C code.
Two tests currently fail (I'm sure there are many bugs still to squash).