Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure no meta loops in Infer #1064

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

johnynek
Copy link
Owner

I don't think loops in the TyMeta graph actually cause a problem, but avoiding them isn't difficult, and makes things a bit simpler to reason about.

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ed5e2ff) 91.97% compared to head (9863beb) 92.22%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1064      +/-   ##
==========================================
+ Coverage   91.97%   92.22%   +0.24%     
==========================================
  Files          93       93              
  Lines        9881     9888       +7     
  Branches     2322     2335      +13     
==========================================
+ Hits         9088     9119      +31     
+ Misses        793      769      -24     
Files Coverage Δ
.../src/main/scala/org/bykn/bosatsu/rankn/Infer.scala 96.87% <93.75%> (+0.04%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnynek johnynek merged commit 000a8a6 into master Oct 26, 2023
13 checks passed
@johnynek johnynek deleted the oscar/20231026_improve_infer_meta branch October 26, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants