Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support recursion in continuations #1045

Merged
merged 7 commits into from
Sep 17, 2023

Conversation

johnynek
Copy link
Owner

replaces #1022

The idea here is that we can recurse on arguments to functions which are themselves allows (substructures).

This allows us to implement functor type things (because to encode those we need existential types, which are encoded as continuations).

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2023

Codecov Report

Patch coverage: 98.21% and project coverage change: +0.13% 🎉

Comparison is base (493c92c) 91.77% compared to head (9e89b24) 91.91%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1045      +/-   ##
==========================================
+ Coverage   91.77%   91.91%   +0.13%     
==========================================
  Files          91       91              
  Lines        9496     9533      +37     
  Branches     2241     2195      -46     
==========================================
+ Hits         8715     8762      +47     
+ Misses        781      771      -10     
Files Changed Coverage Δ
...ain/scala/org/bykn/bosatsu/DefRecursionCheck.scala 98.04% <98.21%> (+0.42%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnynek johnynek merged commit 7890b7b into master Sep 17, 2023
13 checks passed
@johnynek johnynek deleted the oscar/20230916_continuation_recursion branch September 17, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants