Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support polymorphic recursion #1041

Merged
merged 3 commits into from
Sep 16, 2023
Merged

Conversation

johnynek
Copy link
Owner

This make monomorphization very hard (if not impossible) but removing this if we decide we really want monomorphization can be done.

In the mean time, I'm interested in exploring more powerful recursions that still provable terminate, and some examples I've hit require polymorphic recursion.

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.09% 🎉

Comparison is base (dd86eea) 91.74% compared to head (d43c6b7) 91.83%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1041      +/-   ##
==========================================
+ Coverage   91.74%   91.83%   +0.09%     
==========================================
  Files          91       91              
  Lines        9487     9496       +9     
  Branches     2224     2241      +17     
==========================================
+ Hits         8704     8721      +17     
+ Misses        783      775       -8     
Files Changed Coverage Δ
core/src/main/scala/org/bykn/bosatsu/Expr.scala 87.83% <100.00%> (+0.69%) ⬆️
.../main/scala/org/bykn/bosatsu/SourceConverter.scala 97.59% <100.00%> (ø)
.../src/main/scala/org/bykn/bosatsu/rankn/Infer.scala 95.63% <100.00%> (-0.17%) ⬇️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnynek johnynek merged commit 493c92c into master Sep 16, 2023
13 checks passed
@johnynek johnynek deleted the oscar/20230910_polymorphic_recursion branch September 16, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants