Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and unify free type variable handling #1040

Merged
merged 1 commit into from
Sep 10, 2023

Conversation

johnynek
Copy link
Owner

This changes to require that all expressions being type checked by Infer have no free type variables. The caller needs to put the bounds in the correct places by using Generic(_, _). This is done in SourceConverter rather than spreading the logic around.

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.06% ⚠️

Comparison is base (ec40f58) 91.80% compared to head (a927efe) 91.75%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1040      +/-   ##
==========================================
- Coverage   91.80%   91.75%   -0.06%     
==========================================
  Files          91       91              
  Lines        9487     9487              
  Branches     2172     2224      +52     
==========================================
- Hits         8710     8705       -5     
- Misses        777      782       +5     
Files Changed Coverage Δ
core/src/main/scala/org/bykn/bosatsu/Expr.scala 87.14% <100.00%> (+0.57%) ⬆️
.../main/scala/org/bykn/bosatsu/SourceConverter.scala 97.59% <100.00%> (+<0.01%) ⬆️
.../src/main/scala/org/bykn/bosatsu/rankn/Infer.scala 95.79% <100.00%> (-0.05%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnynek johnynek merged commit dd86eea into master Sep 10, 2023
13 checks passed
@johnynek johnynek deleted the oscar/20230910_use_generic_before_infer branch September 10, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants