Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more than one parameter group on def #1037

Merged
merged 3 commits into from
Sep 9, 2023

Conversation

johnynek
Copy link
Owner

@johnynek johnynek commented Sep 9, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2023

Codecov Report

Patch coverage: 98.41% and project coverage change: -0.01% ⚠️

Comparison is base (1b3dcdf) 91.75% compared to head (fda3edd) 91.75%.
Report is 4 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1037      +/-   ##
==========================================
- Coverage   91.75%   91.75%   -0.01%     
==========================================
  Files          91       91              
  Lines        9460     9479      +19     
  Branches     2208     2197      -11     
==========================================
+ Hits         8680     8697      +17     
- Misses        780      782       +2     
Files Changed Coverage Δ
...ain/scala/org/bykn/bosatsu/DefRecursionCheck.scala 97.61% <97.50%> (+0.21%) ⬆️
.../src/main/scala/org/bykn/bosatsu/Declaration.scala 98.91% <100.00%> (ø)
...src/main/scala/org/bykn/bosatsu/DefStatement.scala 100.00% <100.00%> (ø)
.../main/scala/org/bykn/bosatsu/SourceConverter.scala 97.56% <100.00%> (+0.01%) ⬆️
...re/src/main/scala/org/bykn/bosatsu/Statement.scala 98.75% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnynek
Copy link
Owner Author

johnynek commented Sep 9, 2023

related to #1026 -- with automatic currying, this syntax is superfluous, but with explicit function sizes, then it is useful when you have cases that will almost always be curried (like building comparison or equality functions from other functions).

@johnynek johnynek merged commit ae52f82 into master Sep 9, 2023
@johnynek johnynek deleted the oscar/20230908_several_param_groups branch September 9, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants