Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avoid unmounting pane with same key which only changes position #226

Merged
merged 3 commits into from
Apr 10, 2022

Conversation

johnwalley
Copy link
Owner

Closes #223.

@johnwalley johnwalley added the enhancement New feature or request label Apr 7, 2022
@johnwalley johnwalley self-assigned this Apr 7, 2022
@netlify
Copy link

netlify bot commented Apr 7, 2022

Deploy Preview for allotment-website ready!

Name Link
🔨 Latest commit d3cff68
🔍 Latest deploy log https://app.netlify.com/sites/allotment-website/deploys/6252ff90c40c4c0009b49416
😎 Deploy Preview https://deploy-preview-226--allotment-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 7, 2022

Deploy Preview for allotment-storybook ready!

Name Link
🔨 Latest commit d3cff68
🔍 Latest deploy log https://app.netlify.com/sites/allotment-storybook/deploys/6252ff9096faa900083c046f
😎 Deploy Preview https://deploy-preview-226--allotment-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@johnwalley johnwalley changed the title feat: avoid unmounting pane with same key which changes position feat: avoid unmounting pane with same key which only changes position Apr 10, 2022
@johnwalley johnwalley merged commit f7d077a into main Apr 10, 2022
@johnwalley johnwalley deleted the move-pane-to-avoid-unmount-and-mount branch April 10, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing order of panes should not cause components to remount
1 participant