Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Added a hosting/docker/Dockerfile into each application path and added a Makefile that allows quick validation of build, e.g.
make build-fe
. Additionally,make deploy
immediately deploys the two tags of si-assessment-ie3-backend:latest and si-assessment-ie3-frontned:latest, which would be available locally ifmake build-fe
/make build-be
were used. Thelocal-development/docker-compose-stack.yml
file can be manipulated accordingly if the developer or tester wanted to check two different versions of the services together. Onmake deploy
the frontend service can be reached on x and the backend service can be reached on y. Also individually added amake validate-be
andmake validate-fe
function to quickly validate the basic http integrity of the application variant. This ensures that no code changes makes it very far without maintaining application integrity while the unit-tests and other code-validation still pass. This should stop non-compatible changes in the origin baseimage adversely affecting the compatibility with the code at a basic level.- Added all the above checks in a basic CI build pipeline
-
frontend/src/stores/task.ts
andfrontend/src/stores/user.ts
were adjusted (poorly) to allow the backend and frontend to talk together in a docker-based environment. This could be refactored later to be an environment variable or similar.- Chore/add build ci #4
- Chore/add build ci #4