Fix test failures in Travis CI #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the setUp/tearDown methods which have changed their signature in PhpUnit 8.0
beforeClass only runs once before the test suite, whereas before runs before each test. Now the install paths get reset before each test and they get reset after the whole suite.
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
=======================================
Coverage 100% 100%
Complexity 17 17
=======================================
Files 2 2
Lines 35 35
=======================================
Hits 35 35Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that PhpUnit 8.0 is out, the test classes need to be updated to stop from breaking. I'd also like to add PHP 7.3 to the tested versions.