Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: edits from Andrew #564

Merged
merged 5 commits into from
May 9, 2023
Merged

fix: edits from Andrew #564

merged 5 commits into from
May 9, 2023

Conversation

johnnyreilly
Copy link
Owner

No description provided.

@github-actions
Copy link

github-actions bot commented May 9, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-sky-0bfc7e803-564.westeurope.1.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented May 9, 2023 •
edited
Loading

⚡️🏠 Lighthouse report

We ran Lighthouse against the changes and produced this report. Here's the summary:

Category Score
🟠 Performance 70
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 90
🟢 PWA 100

Lighthouse ran against https://thankful-sky-0bfc7e803-564.westeurope.1.azurestaticapps.net/

andrewbranch
andrewbranch reviewed May 9, 2023
View reviewed changes
Copy link
Contributor

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

...2023-05-09-typescript-5-importsnotusedasvalues-error-eslint-consistent-type-imports/index.md Outdated Show resolved Hide resolved
...2023-05-09-typescript-5-importsnotusedasvalues-error-eslint-consistent-type-imports/index.md Outdated Show resolved Hide resolved
@johnnyreilly @andrewbranch
Update blog-website/blog/2023-05-09-typescript-5-importsnotusedasvalu…
a1a4706 
…es-error-eslint-consistent-type-imports/index.md

Co-authored-by: Andrew Branch <[email protected]>
@github-actions
Copy link

github-actions bot commented May 9, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-sky-0bfc7e803-564.westeurope.1.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented May 9, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-sky-0bfc7e803-564.westeurope.1.azurestaticapps.net

johnnyreilly and others added 2 commits May 9, 2023 19:28
@johnnyreilly @andrewbranch
Update blog-website/blog/2023-05-09-typescript-5-importsnotusedasvalu…
4b46d59 
…es-error-eslint-consistent-type-imports/index.md

Co-authored-by: Andrew Branch <[email protected]>
@johnnyreilly @andrewbranch
Update blog-website/blog/2023-05-09-typescript-5-importsnotusedasvalu…
365afda 
…es-error-eslint-consistent-type-imports/index.md

Co-authored-by: Andrew Branch <[email protected]>
andrewbranch
andrewbranch approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@github-actions
Copy link

github-actions bot commented May 9, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-sky-0bfc7e803-564.westeurope.1.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented May 9, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-sky-0bfc7e803-564.westeurope.1.azurestaticapps.net

@johnnyreilly johnnyreilly merged commit 2ba2998 into main May 9, 2023
@johnnyreilly johnnyreilly deleted the consistent-type-imports-nits branch May 9, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnnyreilly @andrewbranch