Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filename options for split (iss. #1365) #1366

Merged
merged 7 commits into from
Aug 23, 2023

Commits on Aug 21, 2023

  1. johnkerl#1365 - filename options for split

    * Don't use joiner string when prefix is empty.
    * Add option to specify joiner string.
    * Add option to not URL-escape file names.
    sloanlance committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    17c389f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    967fb5f View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. johnkerl#1365 - don't URL-escape file name prefix

    I **_thought_** it'd be cool to apply URL-escaping to the file name prefix as well, just in case it included spaces or other characters.  I forgot that a common use for the prefix is to specify a directory path that will contain the file.  When the slashes ("`/`") of the path are URL-escaped, they become "`%2F`" and the directories will not be created.  So, I moved the prefix handling code to come after the URL-escaping.
    sloanlance committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    78083e2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    21169da View commit details
    Browse the repository at this point in the history
  3. johnkerl#1365 - fix escape/suffix logic error

    Trying to make the `return` statement cleaner, I thought it'd be good to add the file name suffix immediately after the file name is URL-escaped.  I'd forgotten that the suffix will not be added if the new `-e` option is used to skip URL-escaping.  So, I put the suffix back where I had it.
    sloanlance committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    a8b7a77 View commit details
    Browse the repository at this point in the history
  4. johnkerl#1365 - add split to the "10 minutes" document

    Not strictly part of this issue, but as I was checking for docs that I should update as a result of my changes, I noticed this document showed how to split data using the `put` and `tee` combination, but not about the `split` verb.
    sloanlance committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    792ee11 View commit details
    Browse the repository at this point in the history
  5. johnkerl#1365 - updated manpage

    When I ran `make dev`, generating `data-diving-examples.md` failed.  The two `manpage.txt` files ended up empty, but `mlr.1` seems to be correct.
    sloanlance committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    0279dc0 View commit details
    Browse the repository at this point in the history