Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Certificates page #87

Closed
4 tasks done
johnchoi96 opened this issue Feb 27, 2023 · 0 comments · Fixed by #208
Closed
4 tasks done

Optimize Certificates page #87

johnchoi96 opened this issue Feb 27, 2023 · 0 comments · Fixed by #208
Assignees
@johnchoi96
Labels
feature New feature or request

Comments

@johnchoi96
Copy link
Owner

johnchoi96 commented Feb 27, 2023 •
edited
Loading

A/C:

  • Apply similar logic from the Diplomas page for the pdf component
  • Margin, background color, paddings are correctly rendered
  • Correctly adapts to the current theme
  • Incomplete page modal is removed
@johnchoi96 johnchoi96 added the feature New feature or request label Feb 27, 2023
@johnchoi96 johnchoi96 self-assigned this Feb 27, 2023
johnchoi96 added a commit that referenced this issue Aug 4, 2024
@johnchoi96
Fixed Issues #87 #151 #204 and #205
8191467
@johnchoi96 johnchoi96 linked a pull request Aug 4, 2024 that will close this issue
Fixed Issues #87 #151 #204 and #205 #208
Merged
johnchoi96 added a commit that referenced this issue Aug 4, 2024
@johnchoi96
Merge pull request #208 from johnchoi96/bugfix/204-diploma-fix
ed0b412 
Fixed Issues #87 #151 #204 and #205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnchoi96 johnchoi96

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed Issues #87 #151 #204 and #205 johnchoi96/johnchoi96.github.io
1 participant
@johnchoi96