This repository has been archived by the owner on Jun 16, 2020. It is now read-only.
Refactored and simplified Sprockets asset caching #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allows for manipulation of the Sprockets::Environment for
things like adding/removing pre/postprocessors from spec_helper.rb
* Also, fixed specs that were failing on files_list.rb when
run standalone due to missing require in file_checker.rb
* Done primarily so postprocessors would work properly
(i.e. sprockets-commonjs)
* Potentially eliminates need for all the JHW specific template
engines, except NilTemplate
|
I went ahead and removed the JHW specific template engines and their specs. All the features still pass and specs are in the same state. I did just notice, however, that with my current approach coffeescript caching can not be turned off anymore so that the JS was inlined. I'm not really sure that was all that useful, but it could be added back in... and not just for coffeescript like before. Let me know if you would like to see it back in. Also, forgot to say thanks for all your hard work on JHW... much appreciated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: All the features still pass and the only two spec failures were there prior to my changes. If I have a chance I will dig into fixing them as well later.