The typings issue while upgrade to [email protected]

[tianyingchun]

after we upgrade to webpack@5 it will throw typings errors

// `clean-webpack-plugin.d.ts`
import { Compiler, Stats, Compilation as compilnType } from 'webpack';
declare type Compilation = compilationType.Compilation;
export interface Options {
....
}

Maybe it should changed to

import { Compiler, Stats, Compilation } from 'webpack';
export interface Options {
....
}

[joeldenning]

Is there any known workaround for this? For now I am removing clean-webpack-plugin from shared webpack configs in create-single-spa, since it throws typescript errors with webpack 5.

[strootje]

@johnagan I am trying to update this package to webpack v5. But would like some help. See my branch: master...strootje:update-webpack-v5

It seems that the .map files aren't being removed. which makes me assume that they've been removed from the assets map. Got any clue's?

[tianyingchun]

what progress about this issue

[alexander-akait]

You don't need this plugin with webpack v5, please look at output.clean: true option

[shanedg]

@alexander-akait thanks for pointing this out! At the moment, Webpack 5 guides still recommend this plugin for cleaning the dist/ folder and a clean option is missing under output configuration.

FYI there's a new, internal CleanPlugin

Here's the relevant bit in the Webpack 5 src: https://github.com/webpack/webpack/blob/master/lib/WebpackOptionsApply.js#L181-L186

[johnagan]

FYI there's a new, internal CleanPlugin

That's great! I would be happy to deprecate this one since I don't have time to spend on it anymore.

[alexander-akait]

@shanedg docs was updated https://webpack.js.org/guides/output-management/#cleaning-up-the-dist-folder