Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-capturing groups for IPv4 address detection. #323

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Use non-capturing groups for IPv4 address detection. #323

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e2e4cd
Use non-capturing groups for IPv4 address detection.
elliotwutingfeng Mar 8, 2024
3dc09e4
Format with black
elliotwutingfeng Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tldextract/remote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@
from urllib.parse import scheme_chars

IP_RE = re.compile(
r"^(([0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])\.)"
r"{3}([0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])$"
r"^(?:(?:[0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])\.)"
r"{3}(?:[0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])$",
re.ASCII,
)

scheme_chars_set = set(scheme_chars)
Expand Down