-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove socket.inet_pton #318
Merged
Merged
Changes from 14 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
b5eaa92
Add leading zeroes tests for inet_pton
elliotwutingfeng 3998c08
Format with black
elliotwutingfeng 1844c6d
Remove inet_pton
elliotwutingfeng 26acc45
Try Python 3.8.1 (before leading zero bugfix)
elliotwutingfeng 4a7d0b7
Try Python 3.8.7 (before leading zero bugfix)
elliotwutingfeng 22f2ff7
Use Ubuntu 20.04
elliotwutingfeng d7001c6
Update deprecated linter settings
elliotwutingfeng cf2b9fd
Revert CI changes
elliotwutingfeng 10f021c
Update looks_like_ip docstrings
elliotwutingfeng d42beec
Use old Python 3.8 version
elliotwutingfeng a23d29a
Add test_looks_like_ipv6
elliotwutingfeng 40b5f24
Merge remote-tracking branch 'origin/master' into ip
john-kurkowski 2c158ca
Revert to ubuntu-latest.
elliotwutingfeng bf5c276
Use latest Python version for CI
elliotwutingfeng 6f534f6
Skip leading zeroes test for ipv6 addresses in Windows + Python 3.8
elliotwutingfeng cfb708f
Try to simplify
john-kurkowski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know what generated these linebreak diffs? I'm just curious, to reduce noise in our tooling. The latest version of
black .
andruff format .
don't seem to care about this change either way.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This happened here elliotwutingfeng@d7001c6. I was using ruff v0.2.1, but it doesn't seem to be causing it.