You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ugh, that is unintuitive. Private domains strike again. The check was originally for e.g. tldextract.extract('localhost'), where there is no FQDN to reconstruct. It didn't consider private domains.
Like this comment in #138, if we add a way for each suffix to know whether it is private or not, we could change the check to something like this.
When the extract result's subdomain and domain are both empty, it will return an incorrect empty FQDN.
#174 would be a related issue but it's not the same.
Is this check really necessary?
tldextract/tldextract/tldextract.py
Lines 121 to 124 in d657414
The text was updated successfully, but these errors were encountered: