SqlServerDsc: Enabled PSSA rule violations to fail build (dsccommunit…

…y#1102)

- Changes to SqlServerDsc
  - Enabled PSSA rule violations to fail build in the CI environment.
- Changes to SqlSetup
  - Fixed Script Analyzer rule error.
- Changes to SqlServerDatabaseMail
  - Fixed Script Analyzer rule error.

.MetaTestOptIn.json

@@ -2,5 +2,8 @@
      "Common Tests - Validate Markdown Files",
      "Common Tests - Validate Module Files",
      "Common Tests - Validate Script Files",
-     "Common Tests - Validate Example Files"
-    ]
+     "Common Tests - Validate Example Files",
+     "Common Tests - Required Script Analyzer Rules",
+     "Common Tests - New Error-Level Script Analyzer Rules",
+     "Common Tests - Custom Script Analyzer Rules"
+]

CHANGELOG.md

@@ -11,6 +11,7 @@
     - **Remove-IntegrationLoopbackAdapter:** Removes a new network loopback adapter.
     - **Get-NetIPAddressNetwork:** Returns the IP network address from an IPv4 address
       and prefix length.
+  - Enabled PSSA rule violations to fail build in the CI environment.
 - Changes to Unit Tests
   - [Michael Fyffe (@TraGicCode)](https://github.com/TraGicCode): Updated
     the following resources unit test template to version 1.2.1
@@ -23,6 +24,7 @@
   - Updated the integration tests to stop some services after each integration test.
     This is to save memory on the AppVeyor build worker.
   - Updated the integration tests to use a SQL Server 2016 Service Pack 1.
+  - Fixed Script Analyzer rule error.
 - Changes to SqlRS
   - Updated the integration tests to stop the Reporting Services service after
     the integration test. This is to save memory on the AppVeyor build worker.
@@ -31,6 +33,8 @@
 - Changes to SqlServiceAccount
   - Updated the integration tests to stop some services after each integration test.
     This is to save memory on the AppVeyor build worker.
+- Changes to SqlServerDatabaseMail
+  - Fixed Script Analyzer rule error.
 
 ## 11.1.0.0
 

DSCResources/MSFT_SqlServerDatabaseMail/MSFT_SqlServerDatabaseMail.psm1

@@ -298,7 +298,6 @@ function Set-TargetResource
     {
         if ($Ensure -eq 'Present')
         {
-
             $databaseMailEnabledRunValue = $sqlServerObject.Configuration.DatabaseMailEnabled.RunValue
             if ($databaseMailEnabledRunValue -eq 1)
             {

DSCResources/MSFT_SqlSetup/MSFT_SqlSetup.psm1

@@ -1201,7 +1201,6 @@ function Set-TargetResource
 
     if ($Features.Contains('SQLENGINE'))
     {
-
         if ($PSBoundParameters.ContainsKey('SQLSvcAccount'))
         {
             $setupArguments += (Get-ServiceAccountParameters -ServiceAccount $SQLSvcAccount -ServiceType 'SQL')
@@ -1842,7 +1841,8 @@ function Test-TargetResource
         $boundParameters.Keys | Where-Object {$_ -imatch "^FailoverCluster"} | ForEach-Object {
             $variableName = $_
 
-            if ($getTargetResourceResult.$variableName -ne $boundParameters[$variableName]) {
+            if ($getTargetResourceResult.$variableName -ne $boundParameters[$variableName])
+            {
                 Write-Verbose -Message ($script:localizedData.ClusterParameterIsNotInDesiredState -f $variableName, $($boundParameters[$variableName]))
                 $result = $false
             }