Skip to content

Commit

Permalink
xActiveDirectory: Combine DscResource.LocalizationHelper and DscResou…
Browse files Browse the repository at this point in the history
…rce.Common (dsccommunity#270)

- Changes to xActiveDirectory
  - Combined the DscResource.LocalizationHelper and DscResource.Common
    modules into xActiveDirectory.Common (issue dsccommunity#268).
  • Loading branch information
SSvilen authored and johlju committed May 11, 2019
1 parent 684fd11 commit 720a543
Show file tree
Hide file tree
Showing 12 changed files with 650 additions and 683 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
and [@kungfu71186](https://github.com/kungfu71186)
- Removing the Misc Folder, as it is no longer required.
- Added xADKDSKey resource to create KDS Root Keys for gMSAs. [@kungfu71186](https://github.com/kungfu71186)
- Combined DscResource.LocalizationHelper and DscResource.Common Modules into xActiveDirectory.Common
- Changes to xADReplicationSiteLink
- Make use of the new localization helper functions.
- Changes to xAdDomainController
Expand Down
4 changes: 2 additions & 2 deletions DSCResources/MSFT_xADCommon/MSFT_xADCommon.psm1
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
$script:resourceModulePath = Split-Path -Path (Split-Path -Path $PSScriptRoot -Parent) -Parent
$script:modulesFolderPath = Join-Path -Path $script:resourceModulePath -ChildPath 'Modules'

$script:localizationModulePath = Join-Path -Path $script:modulesFolderPath -ChildPath 'DscResource.LocalizationHelper'
Import-Module -Name (Join-Path -Path $script:localizationModulePath -ChildPath 'DscResource.LocalizationHelper.psm1')
$script:localizationModulePath = Join-Path -Path $script:modulesFolderPath -ChildPath 'xActiveDirectory.Common'
Import-Module -Name (Join-Path -Path $script:localizationModulePath -ChildPath 'xActiveDirectory.Common.psm1')

data localizedString
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
$script:resourceModulePath = Split-Path -Path (Split-Path -Path $PSScriptRoot -Parent) -Parent
$script:modulesFolderPath = Join-Path -Path $script:resourceModulePath -ChildPath 'Modules'

$script:localizationModulePath = Join-Path -Path $script:modulesFolderPath -ChildPath 'DscResource.LocalizationHelper'
Import-Module -Name (Join-Path -Path $script:localizationModulePath -ChildPath 'DscResource.LocalizationHelper.psm1')
$script:localizationModulePath = Join-Path -Path $script:modulesFolderPath -ChildPath 'xActiveDirectory.Common'
Import-Module -Name (Join-Path -Path $script:localizationModulePath -ChildPath 'xActiveDirectory.Common.psm1')

$script:localizedData = Get-LocalizedData -ResourceName 'MSFT_xADDomainController'

Expand Down
4 changes: 2 additions & 2 deletions DSCResources/MSFT_xADKDSKey/MSFT_xADKDSKey.psm1
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ $script:resourceModulePath = Split-Path `

$script:localizationModulePath = Join-Path `
-Path $script:resourceModulePath `
-ChildPath 'Modules\DscResource.LocalizationHelper'
-ChildPath 'Modules\xActiveDirectory.Common'

Import-Module -Name (
Join-Path `
-Path $script:localizationModulePath `
-ChildPath 'DscResource.LocalizationHelper.psm1'
-ChildPath 'xActiveDirectory.Common.psm1'
)

$script:localizedData = Get-LocalizedData -ResourceName 'MSFT_xADKDSKey'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@ $script:resourceModulePath = Split-Path `

$script:localizationModulePath = Join-Path `
-Path $script:resourceModulePath `
-ChildPath 'Modules\DscResource.LocalizationHelper'
-ChildPath 'Modules\xActiveDirectory.Common'

Import-Module -Name (
Join-Path `
-Path $script:localizationModulePath `
-ChildPath 'DscResource.LocalizationHelper.psm1'
-ChildPath 'xActiveDirectory.Common.psm1'
)

$script:localizedData = Get-LocalizedData -ResourceName 'MSFT_xADManagedServiceAccount'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
$script:resourceModulePath = Split-Path -Path (Split-Path -Path $PSScriptRoot -Parent) -Parent
$script:modulesFolderPath = Join-Path -Path $script:resourceModulePath -ChildPath 'Modules'

$script:localizationModulePath = Join-Path -Path $script:modulesFolderPath -ChildPath 'DscResource.LocalizationHelper'
Import-Module -Name (Join-Path -Path $script:localizationModulePath -ChildPath 'DscResource.LocalizationHelper.psm1')
$script:localizationModulePath = Join-Path -Path $script:modulesFolderPath -ChildPath 'xActiveDirectory.Common'
Import-Module -Name (Join-Path -Path $script:localizationModulePath -ChildPath 'xActiveDirectory.Common.psm1')

$script:localizedData = Get-LocalizedData -ResourceName 'MSFT_xADReplicationSiteLink'

Expand Down
190 changes: 0 additions & 190 deletions Modules/DscResource.Common/DscResource.Common.psm1

This file was deleted.

Loading

0 comments on commit 720a543

Please sign in to comment.