Pluggable logger #22
Merged
Pluggable logger #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
==========================================
+ Coverage 75.44% 75.89% +0.44%
==========================================
Files 12 13 +1
Lines 900 925 +25
==========================================
+ Hits 679 702 +23
- Misses 154 155 +1
- Partials 67 68 +1
Continue to review full report at Codecov.
|
johannesboyne
approved these changes
Jan 18, 2019
|
ups. I guess my conflict resolution broke it ;-) and I have to get into a meeting marathon now. Will fix later >.< |
|
Oops, totally my fault, I didn't consider the interaction between the two PRs properly. I've fixed it up now, the test should pass. Sorry 'bout that. I hope the meetings are swift, productive and focused! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a refreshingly simple one! A couple of the projects I'm integrating gofakes3 with use different loggers to the standard library's log. I've got a useful little bit of copy-pasta for situations like this which I've popped in to this PR (
log.go). It lets you swap the log out and adapt whatever your project happens to be using easily, and fall back on the standard library's logger even more easily. The CLI tool and tester should both still work exactly as before: the CLI will still log to console, and the tester will still redirect the log to a file. Using gofakes3 directly will no longer generate log output by default though: you have to opt in to the old behaviour usinggofakes3.WithGlobalLog().Go 2 will hopefully convert log.Logger to an interface, which would obviate the need for all this if log library authors get on board and implement it, but we're not there yet unfortunately: golang/go#13182