Update to axum-0.7/hyper-1.2 #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hyper (and by extension axum) remove the `Server` struct on 1.0, this keeps the same API but uses axum::serve under the hood, with a slight change to the Error type returned.
RaoulHC
force-pushed
the
raoul/update-axum
branch
from
c4d97d9
to
c00e230
Compare
|
Realised that actually the bind can be made non-async, as the |
|
@johanhelsing that dead code warning seems unrelated to this change, should the field be made public or have an accessor? It looks like it's meant to be there for debugging |
johanhelsing
approved these changes
Mar 24, 2024
There was a problem hiding this comment.
@johanhelsing that dead code warning seems unrelated to this change, should the field be made public or have an accessor? It looks like it's meant to be there for debugging
Yes, seems unrelated, opened #437
Thanks for fixing this, looks great to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hyper (and by extension axum) removed the
Serverstruct on 1.0, this largely keeps the same API but uses axum::serve under the hood. However bind is now an async function, and the errors are slightly different.Closes #397.