Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide abstraction for a channel #160

Merged
merged 31 commits into from
Mar 25, 2023
Merged

Provide abstraction for a channel #160

merged 31 commits into from
Mar 25, 2023

Commits on Mar 24, 2023

  1. Add WebRtcChannel

    @garryod
    garryod committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    ff89dbb View commit details
    Browse the repository at this point in the history

  2. Remove redundant as_mut

    @garryod
    garryod committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    44abe21 View commit details
    Browse the repository at this point in the history

  3. Re-add new_senders_and_receivers

    @garryod
    garryod committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    935e61e View commit details
    Browse the repository at this point in the history

  4. Return result from channel getters

    @garryod
    garryod committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    305bd03 View commit details
    Browse the repository at this point in the history

  5. Refactor WebRtcChannel creation

    @garryod
    garryod committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    d5d557d View commit details
    Browse the repository at this point in the history

  6. Remove returns None from channel getter docstrings

    @garryod
    garryod committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    dca79b5 View commit details
    Browse the repository at this point in the history

  7. Remove option hack from bevy ggrs example

    @garryod
    garryod committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    a307cae View commit details
    Browse the repository at this point in the history

  8. Make WebRtcSocket generic over channels contents

    @garryod
    garryod committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    a6b0608 View commit details
    Browse the repository at this point in the history

  9. Remove superfluous trait

    @garryod
    garryod committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    84c2470 View commit details
    Browse the repository at this point in the history

  10. Simplify one-channel usage

    @johanhelsing @garryod
    johanhelsing authored and garryod committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    fda1983 View commit details
    Browse the repository at this point in the history

  11. Remove explicit type from simple example

    @garryod
    garryod committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    30d9e79 View commit details
    Browse the repository at this point in the history

  12. Add default type to WebRtcSocketBuilder

    @garryod
    garryod committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    7786a86 View commit details
    Browse the repository at this point in the history

  13. Promote WebRtcSocketBuilder when adding channels

    @garryod
    garryod committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    de06b92 View commit details
    Browse the repository at this point in the history

  14. Simplify add_channel for multiple channels

    @garryod
    garryod committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    3f825da View commit details
    Browse the repository at this point in the history

  15. Add doctest to take_channel

    @garryod
    garryod committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    a862797 View commit details
    Browse the repository at this point in the history

  16. Clean up docs

    @garryod
    garryod committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    3b7fa34 View commit details
    Browse the repository at this point in the history

  17. Add doctest to channel

    @garryod
    garryod committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    ec9171b View commit details
    Browse the repository at this point in the history

  18. Use ChannelPlurality trait for type state

    @garryod
    garryod committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    b0e9003 View commit details
    Browse the repository at this point in the history

  19. Add trait to tag buildabe quantities

    @garryod
    garryod committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    ccb891d View commit details
    Browse the repository at this point in the history

  20. Allow channel access for single channel sockets

    @garryod
    garryod committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    e975543 View commit details
    Browse the repository at this point in the history

  21. Factor out socket config

    @garryod
    garryod committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    a3a9ce6 View commit details
    Browse the repository at this point in the history

  22. Allow basic method access regardless of channels

    @garryod
    garryod committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    4531492 View commit details
    Browse the repository at this point in the history

  23. Use deref in bevy ggrs example

    @garryod
    garryod committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    6fdfdb4 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2023

  1. Specify mutable reference for channel getter 

    Co-authored-by: Johan Klokkhammer Helsing <[email protected]>
    @garryod @johanhelsing
    garryod and johanhelsing authored Mar 25, 2023
    Configuration menu
    Copy the full SHA
    751c77f View commit details
    Browse the repository at this point in the history

  2. Fix spelling in WebRtcChannel docstring 

    Co-authored-by: Johan Klokkhammer Helsing <[email protected]>
    @garryod @johanhelsing
    garryod and johanhelsing authored Mar 25, 2023
    Configuration menu
    Copy the full SHA
    43a045a View commit details
    Browse the repository at this point in the history

  3. Correctly reference WebRtcChannel in WebRtcSocket docstring 

    Co-authored-by: Johan Klokkhammer Helsing <[email protected]>
    @garryod @johanhelsing
    garryod and johanhelsing authored Mar 25, 2023
    Configuration menu
    Copy the full SHA
    377246a View commit details
    Browse the repository at this point in the history

  4. Fix spelling in NoChannels docstring 

    Co-authored-by: Johan Klokkhammer Helsing <[email protected]>
    @garryod @johanhelsing
    garryod and johanhelsing authored Mar 25, 2023
    Configuration menu
    Copy the full SHA
    1ced9e4 View commit details
    Browse the repository at this point in the history

  5. Fix spelling in SingleChannel docstring 

    Co-authored-by: Johan Klokkhammer Helsing <[email protected]>
    @garryod @johanhelsing
    garryod and johanhelsing authored Mar 25, 2023
    Configuration menu
    Copy the full SHA
    ee8640d View commit details
    Browse the repository at this point in the history

  6. Fix spelling in MultipleChannels docstring 

    Co-authored-by: Johan Klokkhammer Helsing <[email protected]>
    @garryod @johanhelsing
    garryod and johanhelsing authored Mar 25, 2023
    Configuration menu
    Copy the full SHA
    a0a6c4a View commit details
    Browse the repository at this point in the history

  7. Use unreachable for no channel check

    @garryod
    garryod committed Mar 25, 2023
    Configuration menu
    Copy the full SHA
    e28acd0 View commit details
    Browse the repository at this point in the history

  8. Improve get channel error naming

    @garryod
    garryod committed Mar 25, 2023
    Configuration menu
    Copy the full SHA
    02d7107 View commit details
    Browse the repository at this point in the history