Added windows support

[ori-d]

Added windows support, but required to be on branch windows.

[johang]

Interesting. Do you have instructions for compiling on Windows?

[ori-d]

Interesting. Do you have instructions for compiling on Windows?

Yes, I have, but i need some more time I think 2d. So don't merge it now, found a bug with open URL, so vlc just got crashed.

[ori-d]

I'm going to create CMakeLists.txt for this project, because auto tools are too complicated for me.

[petterreinholdtsen]

Do you now have a recipe for building on Windows?

[petterreinholdtsen]

I guess this effort has stopped up. Perhaps someone else want to pick up the task?

[johang]

I'm not against merging support for building for Windows, but I'm not interested in merging this patch. It's huge and unmaintainable.

[petterreinholdtsen]

[Johan Gunnarsson]

I'm not against merging support for building for Windows, but I'm not interested in merging this patch. It's huge and unmaintainable.

What kind of approach do you believe is maintainable? Would switching all architectures to cmake be an ok alternative? I do not use Windows myself, but think it is a good idea to bring this add-on to more people. :)

…

-- Happy hacking Petter Reinholdtsen

[johang]

Would switching all architectures to cmake be an ok alternative?

Yes, absolutely. Cmake or Meson or something else.

I do not use Windows myself

Same. So I can't test or maintain any of this myself.

[evo-i]

I can do it, I need time. Starting tomorrow...

[evo-i]

Build ready, need more time for optimize building process
https://www.youtube.com/watch?v=BrJxPM-_mLc

First of all, change the build system to CMake.

[evo-i]

@johang can u fix all deprecated warnings before I made a patch?

[petterreinholdtsen]

[evo]

@johang can u fix all deprecated warnings before I made a patch?

Why should that matter for the build system?

…

-- Happy hacking Petter Reinholdtsen

[evo-i]

Because compile time are too long with warnings. And quality of code, can be better =)

[petterreinholdtsen]

[evo]

Because compile time are too long with warnings. And quality of code, can be better =)

I believe both are ortogonal issues, that should not block adding Windows build support. With GCC, the compile time is the same with and without warnings. I am not saying it should not be fixed, I am saying it should be fixed with an independent timeline not mixed with this one.

…

-- Happy hacking Petter Reinholdtsen

[evo-i]

Okay, the build system was already writen, so need to fix bug with VLC headers, where vlc_poll function was called with macro poll, and on windows has conflicting with other poll function. I'll try to fix it before make any of pull requestes.

static inline int vlc_poll(struct pollfd *fds, unsigned nfds, int timeout)
{
    int val;

    vlc_testcancel();
    val = poll(fds, nfds, timeout);
    if (val < 0)
        vlc_testcancel();
    return val;
}
# define poll(u,n,t) vlc_poll(u, n, t)
/* /\ /\ /\ /\ /\ /\ /\ /\ /\ /\ /\ /\ /\
   ------------------------------ */

[johang]

It's now possible to build with CMake on master.