Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits to manuscript and other files #38

Merged
merged 6 commits into from
Jun 5, 2020
Merged

Edits to manuscript and other files #38

merged 6 commits into from
Jun 5, 2020

Conversation

joglekara
Copy link
Owner

Edits as requested by @TomGoffrey

joglekara added 3 commits May 29, 2020 07:33
…, and applied math/fundamental plasma physics.
newline at the end of CONTRIBUTING.md
newline at the end of README.md
@TomGoffrey
Copy link

Thanks @joglekara from a quick check these look great.

@codecov
Copy link

codecov bot commented May 30, 2020

Codecov Report

Merging #38 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #38   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files           6        6           
  Lines         233      233           
=======================================
  Hits          229      229           
  Misses          4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a9d7ea...23f16e1. Read the comment docs.

@joglekara
Copy link
Owner Author

@TomGoffrey, any more thoughts on this one or should I go ahead and merge?

Copy link
Contributor

@StanczakDominik StanczakDominik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look like good edits to me! 👍

@TomGoffrey
Copy link

Also looks good to me.

@joglekara
Copy link
Owner Author

Thanks all!

@joglekara joglekara merged commit 0c3e05d into master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants