-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Issue #307 #308
Open
xmi666
wants to merge
14
commits into
jofpin:master
Choose a base branch
from
xmi666:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fixing Issue #307 #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update socket.io. Because it wasn't compatible anymore with the newer versions that are used within the python code.
The repo seems to need some attention. Almost nothing works at the moment. So i think, getting more verbose error output helps in the process.
JSON doesn't handle bytestreams properly
Hey again. I fixed a bunch of other Issues. However the program still isn't working fully. I'm trying my best to get it fully functional again. |
this is a pip freeze after installing all dependencies including versions.
Removing old dependenciesthat are not needed anymore
…ing Windows support. I hope this 'rework' makes the code more readable. I am by no means an expert but i feel like it helps. If there is someone who could look at the javascript, i have some ideas that i would like to discuss.
Sergo2106
approved these changes
Jul 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I fixed an issue which crashed the program for multiple users. It was just a wrong argument for the ArgumentParser Class in trape.py line 77. Feel free to review.
Thanks a lot and cheers.